carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xuchuanyin <...@git.apache.org>
Subject [GitHub] carbondata pull request #1921: [CARBONDATA-2124][Streaming] Fix bugs in stre...
Date Sat, 03 Feb 2018 09:16:10 GMT
GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/1921

    [CARBONDATA-2124][Streaming] Fix bugs in streaming ingest from file source

    The test in `TestStreamingTableOperation#Line235` only check the total row number. Actually
the data ingest from file source are null.
    
    tests are updated for this case
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [X] Any interfaces changed?
     `Only internal interfaces are changed`
     - [X] Any backward compatibility impacted?
     `NO`
     - [X] Document update required?
    `NO`
     - [X] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
    `Tests are updated`
            - How it is tested? Please attach test report.
    `Tested in local machine`
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella
JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata 0203_fix_bugs_in_streaming_ingest_from_file_source

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1921.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1921
    
----
commit 9e5fa4a14751eaf2ee9165f0de8c0003ddbfa8c8
Author: xuchuanyin <xuchuanyin@...>
Date:   2018-02-03T09:05:20Z

    Fix bugs in streaming ingest from file source
    
    tests are updated for this case

----


---

Mime
View raw message