carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From QiangCai <...@git.apache.org>
Subject [GitHub] carbondata pull request #1967: [CARBONDATA-1997] Add CarbonWriter SDK API
Date Sun, 11 Feb 2018 03:24:52 GMT
Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1967#discussion_r167419025
  
    --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/Schema.java ---
    @@ -0,0 +1,74 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.sdk.file;
    +
    +import java.io.IOException;
    +
    +import org.apache.carbondata.common.annotations.InterfaceAudience;
    +import org.apache.carbondata.common.annotations.InterfaceStability;
    +
    +import com.google.gson.GsonBuilder;
    +import com.google.gson.TypeAdapter;
    +import com.google.gson.stream.JsonReader;
    +import com.google.gson.stream.JsonWriter;
    +
    +/**
    + * A schema used to write and read data files
    + */
    +@InterfaceAudience.User
    +@InterfaceStability.Unstable
    +public class Schema {
    +
    +  private Field[] fields;
    +
    +  private Schema(Field[] fields) {
    --- End diff --
    
    Suggest public this interface to the user.
    Because it is easy to build this field list


---

Mime
View raw message