carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xubo245 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1878: [CARBONDATA-2094] Filter DataMap Tables in Sh...
Date Thu, 08 Feb 2018 07:16:41 GMT
Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1878#discussion_r166847806
  
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/preaggregate/TestPreAggregateDrop.scala
---
    @@ -46,8 +46,9 @@ class TestPreAggregateDrop extends QueryTest with BeforeAndAfterAll
{
           " a,sum(c) from maintable group by a")
         sql("drop datamap if exists preagg2 on table maintable")
         val showTables = sql("show tables")
    +    val showdatamaps =sql("show datamap on table maintable")
         checkExistence(showTables, false, "maintable_preagg2")
    --- End diff --
    
    for example:
    
      test("dropping 1 aggregate table should not drop others") {
         sql(
           "create datamap preagg1 on table maintable using 'preaggregate' as select" +
           " a,sum(b) from maintable group by a")
         sql(
           "create datamap preagg2 on table maintable using 'preaggregate' as select" +
           " a,sum(c) from maintable group by a")
         sql("drop datamap if exists preagg2 on table maintable")
         val showTables = sql("show tables")
         checkExistence(showTables, false, "maintable_preagg2")
    
    showTables will always not contain maintable_preagg2, so we need adapt new show table
function. There are some test case need check again.  @BJangir @jackylk @chenliang613 @sraghunandan
@ravipesala 


---

Mime
View raw message