carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manishgupta88 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1914: [CARBONDATA-2122] Corrected bad record path v...
Date Sat, 03 Feb 2018 11:54:55 GMT
Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1914#discussion_r165812799
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
    @@ -1891,7 +1892,12 @@ public static boolean validateValidIntType(String value) {
        * @return
        */
       public static boolean isValidBadStorePath(String badRecordsLocation) {
    -    return !(null == badRecordsLocation || badRecordsLocation.length() == 0);
    +    if (StringUtils.isEmpty(badRecordsLocation)) {
    +      return false;
    +    }
    +    else {
    --- End diff --
    
    move else in above line


---

Mime
View raw message