carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1919: [CARBONDATA-2123] Refactor datamap schema thr...
Date Sat, 03 Feb 2018 08:52:58 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1919#discussion_r165809189
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/datamap/DataMapProvider.java
---
    @@ -27,6 +27,40 @@
      */
     
     public enum DataMapProvider {
    -  PREAGGREGATE,
    -  TIMESERIES;
    +  PREAGGREGATE("org.apache.carbondata.core.datamap.AggregateDataMap", "preaggregate"),
    +  TIMESERIES("org.apache.carbondata.core.datamap.TimeSeriesDataMap", "timeseries");
    +
    +  /**
    +   * Fully qualified class name of datamap
    +   */
    +  private String className;
    +
    +  /**
    +   * Short name representation of datamap
    +   */
    +  private String shortName;
    +
    +  DataMapProvider(String className, String shortName) {
    +    this.className = className;
    +    this.shortName = shortName;
    +  }
    +
    +  public String getClassName() {
    +    return className;
    +  }
    +
    +  private boolean isEqual(String dataMapClass) {
    +    return (dataMapClass != null && (dataMapClass.equals(className) ||
    --- End diff --
    
    move `(dataMapClass.equals(className) ||` to next line to make it more readible


---

Mime
View raw message