carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1860: [CARBONDATA-2080] [S3-Implementation] Propaga...
Date Thu, 01 Feb 2018 05:16:01 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1860#discussion_r165261635
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonRDD.scala
---
    @@ -59,6 +76,33 @@ abstract class CarbonRDD[T: ClassTag](@transient sc: SparkContext,
           map(f => CarbonProperties.getInstance().addProperty(f._1, f._2))
         internalCompute(split, context)
       }
    +
    +  private def getConf: Configuration = {
    +    val configuration = new Configuration(false)
    +    val bai = new ByteArrayInputStream(CompressorFactory.getInstance().getCompressor
    +      .unCompressByte(confBytes))
    +    val ois = new ObjectInputStream(bai)
    +    configuration.readFields(ois)
    +    ois.close()
    +    configuration
    +  }
    +
    +  private def setS3Configurations(hadoopConf: Configuration): Unit = {
    --- End diff --
    
    Can you use the same function in CarbonInputFormatUtil. It was added when I rebase yesterday


---

Mime
View raw message