From issues-return-32916-archive-asf-public=cust-asf.ponee.io@carbondata.apache.org  Mon Jan 29 11:01:31 2018
Return-Path: <issues-return-32916-archive-asf-public=cust-asf.ponee.io@carbondata.apache.org>
X-Original-To: archive-asf-public@eu.ponee.io
Delivered-To: archive-asf-public@eu.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by mx-eu-01.ponee.io (Postfix) with ESMTP id A65A8180654
	for <archive-asf-public@eu.ponee.io>; Mon, 29 Jan 2018 11:01:31 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 96541160C3F; Mon, 29 Jan 2018 10:01:31 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 0E108160C31
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 29 Jan 2018 11:01:30 +0100 (CET)
Received: (qmail 8395 invoked by uid 500); 29 Jan 2018 10:01:30 -0000
Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@carbondata.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@carbondata.apache.org>
List-Post: <mailto:issues@carbondata.apache.org>
List-Id: <issues.carbondata.apache.org>
Reply-To: dev@carbondata.apache.org
Delivered-To: mailing list issues@carbondata.apache.org
Received: (qmail 8386 invoked by uid 99); 29 Jan 2018 10:01:30 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Jan 2018 10:01:30 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 2B896E01EC; Mon, 29 Jan 2018 10:01:30 +0000 (UTC)
From: kumarvishal09 <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1865-carbondata@git.apache.org>
In-Reply-To: <git-pr-1865-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1865: [CARBONDATA-2088][CARBONDATA-1516] Optimize s...
Content-Type: text/plain
Message-Id: <20180129100130.2B896E01EC@git1-us-west.apache.org>
Date: Mon, 29 Jan 2018 10:01:30 +0000 (UTC)

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1865#discussion_r164381622
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonCreateDataMapCommand.scala ---
    @@ -79,32 +79,27 @@ case class CarbonCreateDataMapCommand(
           }
           createPreAggregateTableCommands.flatMap(_.processMetadata(sparkSession))
         } else {
    -      val dataMapSchema = new DataMapSchema(dataMapName, dmClassName)
    -      dataMapSchema.setProperties(new java.util.HashMap[String, String](dmproperties.asJava))
    -      val dbName = CarbonEnv.getDatabaseName(tableIdentifier.database)(sparkSession)
    -      // upadting the parent table about dataschema
    -      PreAggregateUtil.updateMainTable(dbName, tableIdentifier.table, dataMapSchema, sparkSession)
    +      throw new UnsupportedDataMapException(dmClassName)
         }
         LOGGER.audit(s"DataMap $dataMapName successfully added to Table ${ tableIdentifier.table }")
         Seq.empty
       }
     
       override def processData(sparkSession: SparkSession): Seq[Row] = {
    -    if (dmClassName.equals("org.apache.carbondata.datamap.AggregateDataMapHandler") ||
    --- End diff --
    
    I think process meta will handle exception part if class name mentioned in create data map statement is not valid. When call will come to processData or undoMeta validation is already passed so no need to add class validation again


---