From issues-return-31492-archive-asf-public=cust-asf.ponee.io@carbondata.apache.org  Wed Jan 17 18:37:28 2018
Return-Path: <issues-return-31492-archive-asf-public=cust-asf.ponee.io@carbondata.apache.org>
X-Original-To: archive-asf-public@eu.ponee.io
Delivered-To: archive-asf-public@eu.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by mx-eu-01.ponee.io (Postfix) with ESMTP id 978A918062C
	for <archive-asf-public@eu.ponee.io>; Wed, 17 Jan 2018 18:37:28 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 87BBA160C35; Wed, 17 Jan 2018 17:37:28 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id BD7B2160C25
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 17 Jan 2018 18:37:27 +0100 (CET)
Received: (qmail 24676 invoked by uid 500); 17 Jan 2018 17:37:27 -0000
Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@carbondata.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@carbondata.apache.org>
List-Post: <mailto:issues@carbondata.apache.org>
List-Id: <issues.carbondata.apache.org>
Reply-To: dev@carbondata.apache.org
Delivered-To: mailing list issues@carbondata.apache.org
Received: (qmail 24663 invoked by uid 99); 17 Jan 2018 17:37:26 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Jan 2018 17:37:26 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id D4844E178D; Wed, 17 Jan 2018 17:37:26 +0000 (UTC)
From: ravipesala <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1751-carbondata@git.apache.org>
In-Reply-To: <git-pr-1751-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1751: [CARBONDATA-1971][Blocklet Prunning] Measure ...
Content-Type: text/plain
Message-Id: <20180117173726.D4844E178D@git1-us-west.apache.org>
Date: Wed, 17 Jan 2018 17:37:26 +0000 (UTC)

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1751#discussion_r162124619
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelRangeGrtrThanEquaToFilterExecuterImpl.java ---
    @@ -149,13 +154,17 @@ private boolean isScanRequired(byte[] blockMaxValue, byte[][] filterValues) {
         return isScanRequired;
       }
     
    -  private boolean isScanRequired(byte[] maxValue, Object[] filterValue,
    +  private boolean isScanRequired(byte[] maxValue, boolean nullValue, Object[] filterValue,
           DataType dataType) {
         Object value = DataTypeUtil.getMeasureObjectFromDataType(maxValue, dataType);
         for (int i = 0; i < filterValue.length; i++) {
           // TODO handle min and max for null values.
           if (filterValue[i] == null) {
    -        return true;
    +        if (nullValue == true) {
    +          return true;
    +        } else {
    +          return false;
    +        }
    --- End diff --
    
    you no need use if condition, just return nullValue


---