From issues-return-30755-archive-asf-public=cust-asf.ponee.io@carbondata.apache.org  Fri Jan 12 16:06:51 2018
Return-Path: <issues-return-30755-archive-asf-public=cust-asf.ponee.io@carbondata.apache.org>
X-Original-To: archive-asf-public@eu.ponee.io
Delivered-To: archive-asf-public@eu.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by mx-eu-01.ponee.io (Postfix) with ESMTP id 2130C180789
	for <archive-asf-public@eu.ponee.io>; Fri, 12 Jan 2018 16:06:51 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 1177B160C30; Fri, 12 Jan 2018 15:06:51 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 1EBA4160C43
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 12 Jan 2018 16:06:49 +0100 (CET)
Received: (qmail 55580 invoked by uid 500); 12 Jan 2018 15:06:49 -0000
Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@carbondata.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@carbondata.apache.org>
List-Post: <mailto:issues@carbondata.apache.org>
List-Id: <issues.carbondata.apache.org>
Reply-To: dev@carbondata.apache.org
Delivered-To: mailing list issues@carbondata.apache.org
Received: (qmail 55527 invoked by uid 99); 12 Jan 2018 15:06:49 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Jan 2018 15:06:49 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 2AF5ADFBC7; Fri, 12 Jan 2018 15:06:46 +0000 (UTC)
From: jackylk <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1783-carbondata@git.apache.org>
In-Reply-To: <git-pr-1783-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1783: [CARBONDATA-2013] executing alter query resul...
Content-Type: text/plain
Message-Id: <20180112150647.2AF5ADFBC7@git1-us-west.apache.org>
Date: Fri, 12 Jan 2018 15:06:46 +0000 (UTC)

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1783#discussion_r161244611
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/StreamingTableStrategy.scala ---
    @@ -59,7 +59,8 @@ private[sql] class StreamingTableStrategy(sparkSession: SparkSession) extends Sp
               new TableIdentifier(model.tableName, model.databaseName),
               "Alter table change datatype")
             Nil
    -      case AlterTableRenameCommand(oldTableIdentifier, _, _) =>
    +      case AlterTableRenameCommand(
    +      oldTableIdentifier, _, _) if (isCarbonStreamingTable(oldTableIdentifier)) =>
    --- End diff --
    
    Why this if check is needed, `rejectIfStreamingTable` checks whether it is streaming table already.
    Please describe the bug in PR description, otherwise not sure what bug it is.


---