Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7F1CB160C15 for ; Wed, 3 Jan 2018 07:44:23 +0100 (CET) Received: (qmail 3239 invoked by uid 500); 3 Jan 2018 06:44:22 -0000 Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@carbondata.apache.org Delivered-To: mailing list issues@carbondata.apache.org Received: (qmail 3230 invoked by uid 99); 3 Jan 2018 06:44:22 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jan 2018 06:44:22 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 7D2E4DFE46; Wed, 3 Jan 2018 06:44:19 +0000 (UTC) From: jackylk To: issues@carbondata.apache.org Reply-To: issues@carbondata.apache.org References: In-Reply-To: Subject: [GitHub] carbondata pull request #1748: [CARBONDATA-1967][PARTITION] Fix autocompacti... Content-Type: text/plain Message-Id: <20180103064420.7D2E4DFE46@git1-us-west.apache.org> Date: Wed, 3 Jan 2018 06:44:19 +0000 (UTC) archived-at: Wed, 03 Jan 2018 06:44:24 -0000 Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1748#discussion_r159367019 --- Diff: core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java --- @@ -110,6 +110,20 @@ public static boolean isCarbonDataFile(String fileNameWithPath) { return false; } + /** + * check if it is carbon partitionmap file matching extension --- End diff -- change to > Return true if the `fileNameWithPath` ends with partition map file extension name remove @param and @return ---