carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xubo245 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1865: [CARBONDATA-2088][CARBONDATA-1516] Optimize s...
Date Tue, 30 Jan 2018 06:55:52 GMT
Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1865#discussion_r164654217
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DataMapClassName.java
---
    @@ -0,0 +1,52 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.metadata.schema.table;
    +
    +/**
    + * type for create datamap
    + * The syntax of datamap creation is as follows.
    + * CREATE DATAMAP IF NOT EXISTS dataMapName ON TABLE tableName USING 'DataMapClassName'
    + * DMPROPERTIES('KEY'='VALUE') AS SELECT COUNT(COL1) FROM tableName
    + *
    + * Please refer {{org.apache.spark.sql.parser.CarbonSpark2SqlParser}}
    + */
    +
    +public enum DataMapClassName {
    --- End diff --
    
    But now we don't support className. How about change DataMapClassName to DataMapName?


---

Mime
View raw message