carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1875: [CARBONDATA-2092] Fix compaction bug to preve...
Date Tue, 30 Jan 2018 06:50:42 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1875#discussion_r164653466
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/AbstractDataFileFooterConverter.java
---
    @@ -165,6 +165,7 @@ private static BitSet getPresenceMeta(
             dataFileFooter.setBlockInfo(new BlockInfo(tableBlockInfo));
             dataFileFooter.setSegmentInfo(segmentInfo);
             dataFileFooter.setVersionId(tableBlockInfo.getVersion());
    +        dataFileFooter.setSchemaUpdatedTimeStamp(readIndexHeader.getSchema_time_stamp());
    --- End diff --
    
    What if it is from old store? better check `readIndexHeader.isSetSchema_time_stamp` before
setting it to footer


---

Mime
View raw message