carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1860: [CARBONDATA-2080] [S3-Implementation] Propaga...
Date Tue, 30 Jan 2018 06:23:05 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1860#discussion_r164650047
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonRDD.scala
---
    @@ -59,6 +74,33 @@ abstract class CarbonRDD[T: ClassTag](@transient sc: SparkContext,
           map(f => CarbonProperties.getInstance().addProperty(f._1, f._2))
         internalCompute(split, context)
       }
    +
    +  private def getConf = {
    --- End diff --
    
    Move this up to line 59, and provide comment for  `confBytes` and `getConf`


---

Mime
View raw message