carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sraghunandan <...@git.apache.org>
Subject [GitHub] carbondata pull request #1865: [CARBONDATA-2088][CARBONDATA-1516] Optimize s...
Date Mon, 29 Jan 2018 01:52:59 GMT
Github user sraghunandan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1865#discussion_r164323056
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/timeseries/TimeSeriesUtil.scala
---
    @@ -54,6 +56,107 @@ object TimeSeriesUtil {
         }
       }
     
    +  def getGranularityKey(dmProperties: Map[String, String]): String = {
    --- End diff --
    
    why to return the same value? if required only for validation, can change method name
and return true/false


---

Mime
View raw message