carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sounakr <...@git.apache.org>
Subject [GitHub] carbondata pull request #1751: [CARBONDATA-1971][Blocklet Prunning] Measure ...
Date Thu, 18 Jan 2018 09:38:47 GMT
Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1751#discussion_r162289956
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelRangeLessThanFiterExecuterImpl.java
---
    @@ -153,13 +158,17 @@ private boolean isScanRequired(byte[] blockMinValue, byte[][] filterValues)
{
         return isScanRequired;
       }
     
    -  private boolean isScanRequired(byte[] minValue, Object[] filterValue,
    +  private boolean isScanRequired(byte[] minValue, boolean nullValue, Object[] filterValue,
           DataType dataType) {
         Object value = DataTypeUtil.getMeasureObjectFromDataType(minValue, dataType);
         for (int i = 0; i < filterValue.length; i++) {
           // TODO handle min and max for null values.
           if (filterValue[i] == null) {
    -        return true;
    +        if (nullValue == true) {
    +          return true;
    +        } else {
    +          return false;
    +        }
    --- End diff --
    
    Done


---

Mime
View raw message