carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1751: [CARBONDATA-1971][Blocklet Prunning] Measure ...
Date Wed, 17 Jan 2018 17:37:26 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1751#discussion_r162124619
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelRangeGrtrThanEquaToFilterExecuterImpl.java
---
    @@ -149,13 +154,17 @@ private boolean isScanRequired(byte[] blockMaxValue, byte[][] filterValues)
{
         return isScanRequired;
       }
     
    -  private boolean isScanRequired(byte[] maxValue, Object[] filterValue,
    +  private boolean isScanRequired(byte[] maxValue, boolean nullValue, Object[] filterValue,
           DataType dataType) {
         Object value = DataTypeUtil.getMeasureObjectFromDataType(maxValue, dataType);
         for (int i = 0; i < filterValue.length; i++) {
           // TODO handle min and max for null values.
           if (filterValue[i] == null) {
    -        return true;
    +        if (nullValue == true) {
    +          return true;
    +        } else {
    +          return false;
    +        }
    --- End diff --
    
    you no need use if condition, just return nullValue


---

Mime
View raw message