carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kumarvishal09 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1809: [CARBONDATA-2031] Fix ArrayIndexOutOfBoundExc...
Date Tue, 16 Jan 2018 07:30:54 GMT
Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1809#discussion_r161676396
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/ExcludeFilterExecuterImpl.java
---
    @@ -378,6 +378,9 @@ private BitSet setFilterdIndexToBitSet(DimensionColumnDataChunk dimensionColumnD
         BitSet bitSet = new BitSet(numerOfRows);
         bitSet.flip(0, numerOfRows);
         byte[][] filterValues = dimColumnExecuterInfo.getExcludeFilterKeys();
    +    if (filterValues.length == 0) {
    --- End diff --
    
    Please add comment for both Include and exclude when filter can be null


---

Mime
View raw message