carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1783: [CARBONDATA-2013] executing alter query resul...
Date Fri, 12 Jan 2018 15:06:46 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1783#discussion_r161244611
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/StreamingTableStrategy.scala
---
    @@ -59,7 +59,8 @@ private[sql] class StreamingTableStrategy(sparkSession: SparkSession)
extends Sp
               new TableIdentifier(model.tableName, model.databaseName),
               "Alter table change datatype")
             Nil
    -      case AlterTableRenameCommand(oldTableIdentifier, _, _) =>
    +      case AlterTableRenameCommand(
    +      oldTableIdentifier, _, _) if (isCarbonStreamingTable(oldTableIdentifier)) =>
    --- End diff --
    
    Why this if check is needed, `rejectIfStreamingTable` checks whether it is streaming table
already.
    Please describe the bug in PR description, otherwise not sure what bug it is.


---

Mime
View raw message