carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1751: [CARBONDATA-1971][Blocklet Prunning] Measure ...
Date Fri, 05 Jan 2018 09:05:33 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1751#discussion_r159832676
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/FilterExecuter.java
---
    @@ -46,7 +46,7 @@ boolean applyFilter(RowIntf value, int dimOrdinalMax)
        * @param blockMinValue
        * @return BitSet
        */
    -  BitSet isScanRequired(byte[][] blockMaxValue, byte[][] blockMinValue);
    +  BitSet isScanRequired(byte[][] blockMaxValue, byte[][] blockMinValue, byte[] blockNullValue);
    --- End diff --
    
    Better wrap these parameters to new BlockletStats object


---

Mime
View raw message