carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1752: [CARBONDATA-1972][PARTITION] Fix compaction a...
Date Thu, 04 Jan 2018 07:48:40 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1752#discussion_r159594614
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/mutation/DeleteExecution.scala
---
    @@ -58,14 +58,15 @@ object DeleteExecution {
           dataRdd: RDD[Row],
           timestamp: String,
           isUpdateOperation: Boolean,
    -      executorErrors: ExecutionErrors): Boolean = {
    +      executorErrors: ExecutionErrors): (Boolean, Seq[String]) = {
    --- End diff --
    
    It seems the first return value is always true
    And it is hard to understand this function, can you add comment for it


---

Mime
View raw message