carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manishgupta88 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1747: [Compatibility] Added changes for backward co...
Date Thu, 04 Jan 2018 07:00:51 GMT
Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1747#discussion_r159589331
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java
---
    @@ -231,7 +231,22 @@ public String getSchemaFilePath() {
        * @return schema file path
        */
       public static String getSchemaFilePath(String tablePath) {
    -    return tablePath + File.separator + METADATA_DIR + File.separator + SCHEMA_FILE;
    +    return getActualSchemaFilePath(tablePath);
    +  }
    +
    +  private static String getActualSchemaFilePath(String tablePath) {
    +    String metaPath = tablePath + File.separator + METADATA_DIR;
    --- End diff --
    
    use CarbonCommonConstants.FILE_SEPARATOR instead of File.separator


---

Mime
View raw message