carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manishgupta88 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1732: [CARBONDATA-1946] Exception thrown after alte...
Date Thu, 04 Jan 2018 06:08:43 GMT
Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1732#discussion_r159585172
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ---
    @@ -775,4 +775,25 @@ public static DataType valueOf(String name) {
         }
       }
     
    -}
    \ No newline at end of file
    +  /**
    +   * Method to type case the data based on modified data type. This method will used
for
    +   * retrieving the data after change in data type restructure operation
    +   *
    +   * @param data
    +   * @param restructuredDataType
    +   * @param currentDataOffset
    +   * @param length
    +   * @return
    +   */
    +  public static long getDataBasedOnRestructuredDataType(byte[] data, DataType restructuredDataType,
    --- End diff --
    
    yes because alter datatype change is only for Int to BigInt and decimal from lower precision
to higher precision. So float to double case is not required to be handled


---

Mime
View raw message