carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gvramana <...@git.apache.org>
Subject [GitHub] carbondata pull request #1734: [CARBONDATA-1912] Handling lock issues for al...
Date Wed, 03 Jan 2018 10:23:40 GMT
Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1734#discussion_r159394213
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableRenameCommand.scala
---
    @@ -156,18 +156,21 @@ private[sql] case class CarbonAlterTableRenameCommand(
         } catch {
           case e: Exception =>
             LOGGER.error(e, "Rename table failed: " + e.getMessage)
    -        if (carbonTable != null) {
    -          AlterTableUtil
    -            .revertRenameTableChanges(oldTableIdentifier,
    +        try {
    --- End diff --
    
    Still it is unknown, when exception is raised before rename or after rename.
    So better handle unlocking at common place and logic and change table path if rename is
success.


---

Mime
View raw message