carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1748: [CARBONDATA-1967][PARTITION] Fix autocompacti...
Date Wed, 03 Jan 2018 06:44:19 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1748#discussion_r159367019
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java
---
    @@ -110,6 +110,20 @@ public static boolean isCarbonDataFile(String fileNameWithPath) {
         return false;
       }
     
    +  /**
    +   * check if it is carbon partitionmap file matching extension
    --- End diff --
    
    change to 
    > Return true if the `fileNameWithPath` ends with partition map file extension name
    
    remove @param and @return


---

Mime
View raw message