Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B1CF9200D51 for ; Fri, 22 Dec 2017 16:38:38 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B0839160C19; Fri, 22 Dec 2017 15:38:38 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EC72A160BFD for ; Fri, 22 Dec 2017 16:38:37 +0100 (CET) Received: (qmail 63101 invoked by uid 500); 22 Dec 2017 15:38:37 -0000 Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@carbondata.apache.org Delivered-To: mailing list issues@carbondata.apache.org Received: (qmail 63092 invoked by uid 99); 22 Dec 2017 15:38:37 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Dec 2017 15:38:37 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 15683DFC25; Fri, 22 Dec 2017 15:38:37 +0000 (UTC) From: jackylk To: issues@carbondata.apache.org Reply-To: issues@carbondata.apache.org References: In-Reply-To: Subject: [GitHub] carbondata pull request #1720: [CARBONDATA-1935]fix the backword compatibili... Content-Type: text/plain Message-Id: <20171222153837.15683DFC25@git1-us-west.apache.org> Date: Fri, 22 Dec 2017 15:38:37 +0000 (UTC) archived-at: Fri, 22 Dec 2017 15:38:38 -0000 Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1720#discussion_r158512632 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/datatype/DataTypes.java --- @@ -184,4 +224,58 @@ public static boolean isMapType(DataType dataType) { return dataType.getId() == MAP_TYPE_ID; } + /** + * This class is added to support backword compatibility with table info object, where DATATYPE + * is string in old version and OBJECT in new version --- End diff -- It is better to make it an separate java file ---