Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 66046200D6D for ; Tue, 19 Dec 2017 03:36:48 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 646D0160C29; Tue, 19 Dec 2017 02:36:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A23F5160C05 for ; Tue, 19 Dec 2017 03:36:47 +0100 (CET) Received: (qmail 45693 invoked by uid 500); 19 Dec 2017 02:36:46 -0000 Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@carbondata.apache.org Delivered-To: mailing list issues@carbondata.apache.org Received: (qmail 45684 invoked by uid 99); 19 Dec 2017 02:36:46 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Dec 2017 02:36:46 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id B9326DFBBB; Tue, 19 Dec 2017 02:36:46 +0000 (UTC) From: jackylk To: issues@carbondata.apache.org Reply-To: issues@carbondata.apache.org References: In-Reply-To: Subject: [GitHub] carbondata pull request #1672: [CARBONDATA-1858][PARTITION] Support querying... Content-Type: text/plain Message-Id: <20171219023646.B9326DFBBB@git1-us-west.apache.org> Date: Tue, 19 Dec 2017 02:36:46 +0000 (UTC) archived-at: Tue, 19 Dec 2017 02:36:48 -0000 Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1672#discussion_r157652296 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/optimizer/CarbonFilters.scala --- @@ -395,4 +391,14 @@ object CarbonFilters { case _ => expressions } } + + def getPartitions(partitionFilters: Seq[Expression], --- End diff -- I think it is better to do this logic in `pruneFilterProject` directly, this function is not needed ---