Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7E411200D53 for ; Tue, 5 Dec 2017 17:32:59 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 7CC40160C1B; Tue, 5 Dec 2017 16:32:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BBA9A160BF1 for ; Tue, 5 Dec 2017 17:32:58 +0100 (CET) Received: (qmail 78649 invoked by uid 500); 5 Dec 2017 16:32:57 -0000 Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@carbondata.apache.org Delivered-To: mailing list issues@carbondata.apache.org Received: (qmail 78640 invoked by uid 99); 5 Dec 2017 16:32:57 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Dec 2017 16:32:57 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id D6B24E0219; Tue, 5 Dec 2017 16:32:56 +0000 (UTC) From: jackylk To: issues@carbondata.apache.org Reply-To: issues@carbondata.apache.org References: In-Reply-To: Subject: [GitHub] carbondata pull request #1594: [CARBONDATA-1838] Refactor SortStepRowUtil to... Content-Type: text/plain Message-Id: <20171205163256.D6B24E0219@git1-us-west.apache.org> Date: Tue, 5 Dec 2017 16:32:56 +0000 (UTC) archived-at: Tue, 05 Dec 2017 16:32:59 -0000 Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1594#discussion_r155002317 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessorStepOnSpark.scala --- @@ -128,7 +128,7 @@ object DataLoadProcessorStepOnSpark { val model: CarbonLoadModel = modelBroadcast.value.getCopyWithTaskNo(index.toString) val conf = DataLoadProcessBuilder.createConfiguration(model) val sortParameters = SortParameters.createSortParameters(conf) - + val sortStepRowUtil = new SortStepRowUtil(sortParameters) --- End diff -- I think it is ok to create it for each partition ---