Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: ravipesala <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1608-carbondata@git.apache.org>
In-Reply-To: <git-pr-1608-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1608: [CARBONDATA-1761]do not change status of segm...
Content-Type: text/plain
Message-Id: <20171205030003.F22D4DFBEE@git1-us-west.apache.org>
Date: Tue,  5 Dec 2017 03:00:03 +0000 (UTC)
archived-at: Tue, 05 Dec 2017 03:00:06 -0000

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1608#discussion_r154835999
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java ---
    @@ -493,6 +493,19 @@ public static void writeLoadDetailsIntoFile(String dataLoadLocation,
                 invalidLoadIds.add(loadId);
                 return invalidLoadIds;
               }
    +          // if the segment status is in progress then no need to delete that.
    +          if (SegmentStatus.INSERT_IN_PROGRESS == loadMetadata.getSegmentStatus()) {
    +            LOG.error("Cannot delete the Segment which is In Progress. Segment is " + loadId);
    +            invalidLoadIds.add(loadId);
    +            return invalidLoadIds;
    +          }
    +          // if the segment status is overwrite in progress, then no need to delete that.
    +          if (SegmentStatus.INSERT_OVERWRITE_IN_PROGRESS == loadMetadata.getSegmentStatus()) {
    +            LOG.error("Cannot delete the Segment which is Overwrite In Progress. " +
    --- End diff --
    
    Please rephrase the sentence 
    `"Cannot delete the segemnt "+ loadId +" which is load overwrite in progress" `


---