carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mohammadshahidkhan <>
Subject [GitHub] carbondata pull request #1744: [CARBONDATA-1955] Delta DataType calculation ...
Date Sat, 30 Dec 2017 08:20:45 GMT
GitHub user mohammadshahidkhan opened a pull request:

    [CARBONDATA-1955] Delta DataType calculation is incorrect for long type

    In case of Long type, the delta data type is always choosing the Long type.
    But it should choose the datatype based on diff (max-min)  of max and min values.
    Corrected to choose the delta data type based on max and min values.
     - [X] Any interfaces changed?
     - [X] Any backward compatibility impacted?
     **This issue must be synced to 1.2.0 branch**
     - [X] Document update required?
     - [X] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           Added unit test cases to test codec selection
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella

You can merge this pull request into a Git repository by running:

    $ git pull compatibility

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1744
commit 296e52c5d022df347a607decc86aa1eacfe8f30b
Author: mohammadshahidkhan <mohdshahidkhan1987@...>
Date:   2017-12-28T12:42:37Z

    [CARBONDATA-1955] Delta DataType calculation is incorrect for long type



View raw message