carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xuchuanyin <...@git.apache.org>
Subject [GitHub] carbondata pull request #1606: WIP:[CARBONDATA-1839] Fix bugs in compressing...
Date Mon, 04 Dec 2017 10:48:10 GMT
GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/1606

    WIP:[CARBONDATA-1839] Fix bugs in compressing sort temp files

    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [X] Any interfaces changed?
      `YES, ONLY CHANGE INTERNAL INTERFACES`
     - [X] Any backward compatibility impacted?
      `NO`
     - [X] Document update required?
      `YES`
     - [X] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            `ADDED TESTS`
            - How it is tested? Please attach test report.
            `TESTED IN LOCAL CLUSTER`
            - Is it a performance related change? Please attach the performance test report.
            `YES`
            - Any additional information to help reviewers in testing this change.
            `There are some duplicate code in write temp sort files found during this bug
fixing and I plan to optimize it in successive PR not in this one.`
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella
JIRA. 
            `NOT RELATED`
    
    RESOLVE
    ===
    1. fix bugs in compressing sort temp files
    
    2. optimize parameters
    
    3. add tests

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata bug_compress_sort_temp

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1606.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1606
    
----
commit 83e109b6d332dafcc10e243e8bc5a21ac3617ac6
Author: xuchuanyin <xuchuanyin@hust.edu.cn>
Date:   2017-12-01T11:32:00Z

    fix bugs in compressing sort temp files
    
    1. fix bugs in compressing sort temp files
    
    2. optimize parameters
    
    3. add tests

----


---

Mime
View raw message