carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1584: [CARBONDATA-1827][WIP] Added S3 Implementatio...
Date Sat, 30 Dec 2017 08:45:03 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1584#discussion_r159119284
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java
---
    @@ -220,7 +221,16 @@ public static boolean mkdirs(String filePath, FileType fileType)
throws IOExcept
        */
       public static DataOutputStream getDataOutputStreamUsingAppend(String path, FileType
fileType)
           throws IOException {
    -    return getCarbonFile(path).getDataOutputStreamUsingAppend(path, fileType);
    +    if(FileType.S3 == fileType) {
    --- End diff --
    
    add space after `if`


---

Mime
View raw message