carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1728: [CARBONDATA-1926][CARBONDATA-1927][Pre-Aggreg...
Date Fri, 29 Dec 2017 12:56:07 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1728#discussion_r159058055
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonPreAggregateRules.scala
---
    @@ -1124,92 +1328,57 @@ case class CarbonPreAggregateQueryRules(sparkSession: SparkSession)
extends Rule
        *
        * @param carbonTable
        * parent table
    -   * @param aggFunctions
    -   * aggregation function
    -   * @param tableName
    -   * parent table name
    +   * @param aggExp
    +   * aggregate expression
        * @return list of fields
        */
       def validateAggregateFunctionAndGetFields(carbonTable: CarbonTable,
    -      aggFunctions: AggregateFunction,
    -      tableName: String
    -  ): Seq[QueryColumn] = {
    +      aggExp: AggregateExpression): Seq[AggregateExpression] = {
         val changedDataType = true
    --- End diff --
    
    Remove unused variable


---

Mime
View raw message