carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1738: [CARBONDATA-1932]Add version info for CarbonD...
Date Fri, 29 Dec 2017 07:59:22 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1738#discussion_r159034001
  
    --- Diff: core/src/test/java/org/apache/carbondata/core/constants/CarbondataVersionUnitTest.java
---
    @@ -0,0 +1,34 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.constants;
    +
    +import org.apache.carbondata.core.constants.CarbonVersionConstants;
    +import org.apache.commons.lang3.StringUtils;
    +import org.junit.Test;
    +
    +import static junit.framework.TestCase.assertTrue;
    +
    +public class CarbondataVersionUnitTest {
    +
    +  @Test public void testCarbonVersionNotNull() {
    +    assertTrue(StringUtils.isNoneEmpty(CarbonVersionConstants.CARBONDATA_VERSION));
    --- End diff --
    
    can you add verification for the version string also. It is ok that we modify this testcase
before version release


---

Mime
View raw message