carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1734: [CARBONDATA-1912] Handling lock issues for al...
Date Thu, 28 Dec 2017 15:09:35 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1734#discussion_r158955988
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableRenameCommand.scala
---
    @@ -156,15 +156,20 @@ private[sql] case class CarbonAlterTableRenameCommand(
         } catch {
           case e: Exception =>
             LOGGER.error(e, "Rename table failed: " + e.getMessage)
    -        if (carbonTable != null) {
    -          AlterTableUtil
    -            .revertRenameTableChanges(oldTableIdentifier,
    -              newTableName,
    -              carbonTable.getTablePath,
    -              carbonTable.getCarbonTableIdentifier.getTableId,
    -              timeStamp)(
    -              sparkSession)
    -          renameBadRecords(newTableName, oldTableName, oldDatabaseName)
    +        try {
    +          if (carbonTable != null) {
    +            AlterTableUtil
    +              .revertRenameTableChanges(oldTableIdentifier,
    --- End diff --
    
    please follow code convention: 
    ```
         AlterTableUtil. revertRenameTableChanges(
             xxx,
             yyy
         )
    ```


---

Mime
View raw message