carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1707: [CARBONDATA-1839] [DataLoad] Fix bugs and opt...
Date Thu, 28 Dec 2017 06:12:11 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1707#discussion_r158901253
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/holder/UnsafeSortTempFileChunkHolder.java
---
    @@ -296,11 +200,12 @@ private void fillDataForPrefetch() {
        * @throws CarbonSortKeyAndGroupByException
        */
       private Object[] getRowFromStream() throws CarbonSortKeyAndGroupByException {
    -    Object[] row = new Object[dimensionCount + measureCount];
    +    Object[] row = new Object[sortParameters.getDimColCount()
    +        + sortParameters.getComplexDimColCount() + sortParameters.getMeasureColCount()];
    --- End diff --
    
    I think there is difference with changed code compare to old code. Please double check
the changes. Complex dimensions may not work


---

Mime
View raw message