carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sounakr <...@git.apache.org>
Subject [GitHub] carbondata pull request #1650: [CARBONDATA-1703] Refactored code for creatio...
Date Wed, 27 Dec 2017 15:27:00 GMT
Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1650#discussion_r158826141
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/optimizer/CarbonFilters.scala
---
    @@ -78,13 +78,25 @@ object CarbonFilters {
               Some(new LessThanEqualToExpression(getCarbonExpression(name),
                 getCarbonLiteralExpression(name, value)))
             case sources.In(name, values) =>
    -          Some(new InExpression(getCarbonExpression(name),
    -            new ListExpression(
    -              convertToJavaList(values.map(f => getCarbonLiteralExpression(name, f)).toList))))
    +          if (values.length == 1 && values(0) == null) {
    +            Some(new InExpression(getCarbonExpression(name),
    --- End diff --
    
    In case there are only one value in In list and that is also qualifies as Null, then why
cant we return False expression just like Not In case. i.e. Some(new FalseExpression(getCarbonExpression(name))).
    
    



---

Mime
View raw message