carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kumarvishal09 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1724: [CARBONDATA-1940][PreAgg] Fixed bug for creat...
Date Tue, 26 Dec 2017 16:04:58 GMT
Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1724#discussion_r158718033
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala
---
    @@ -144,6 +144,16 @@ object PreAggregateUtil {
             throw new MalformedCarbonCommandException(s"Unsupported Select Statement:${
               selectStmt } ")
         }
    +    groupByExp map {
    +      case attr: AttributeReference =>
    +        fieldToDataMapFieldMap += getField(attr.name,
    +          attr.dataType,
    +          parentColumnId = carbonTable.getColumnByName(parentTableName, attr.name).getColumnId,
    +          parentTableName = parentTableName,
    +          parentDatabaseName = parentDatabaseName, parentTableId = parentTableId)
    +      case _ =>
    +        throw new MalformedCarbonCommandException(s"Expression in group by clause is
incorrect")
    --- End diff --
    
    Please update the exception message 
    throw new MalformedCarbonCommandException(s"Unsupported Function in select Statement:${
              selectStmt }


---

Mime
View raw message