carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From QiangCai <...@git.apache.org>
Subject [GitHub] carbondata pull request #1584: [CARBONDATA-1827] Added S3 Implementation
Date Mon, 25 Dec 2017 04:06:14 GMT
Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1584#discussion_r158614782
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
    @@ -762,14 +762,12 @@ public static String checkAndAppendFileSystemURIScheme(String filePath)
{
       }
     
       private static boolean checkIfPrefixExists(String path) {
    -    final String lowerPath = path.toLowerCase(Locale.getDefault());
    -    return lowerPath.startsWith(CarbonCommonConstants.HDFSURL_PREFIX) ||
    -        lowerPath.startsWith(CarbonCommonConstants.VIEWFSURL_PREFIX) ||
    -        lowerPath.startsWith(CarbonCommonConstants.LOCAL_FILE_PREFIX) ||
    -        lowerPath.startsWith(CarbonCommonConstants.ALLUXIOURL_PREFIX) ||
    -        lowerPath.startsWith(CarbonCommonConstants.S3N_PREFIX) ||
    --- End diff --
    
    why remove S3N_PREFIX and S3_PREFIX ?


---

Mime
View raw message