carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1716: [CARBONDATA-1933] Support Spark 2.2.1 in carb...
Date Sat, 23 Dec 2017 03:56:04 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1716#discussion_r158575701
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CarbonScalaUtil.scala
---
    @@ -158,7 +159,9 @@ object CarbonScalaUtil {
           dataType: DataType,
           timeStampFormat: SimpleDateFormat,
           dateFormat: SimpleDateFormat,
    -      serializationNullFormat: String): UTF8String = {
    +      serializationNullFormat: String,
    +      failAction: Boolean,
    +      ignoreAction: Boolean): UTF8String = {
    --- End diff --
    
    We passed these parameters to throw an exception or ignore it in case of bad records.
 It is not good to handle in caller as it is per each column, not for row so caller code will
become messy if we try to handle there. 
    I will give comments to the parameters for understanding,


---

Mime
View raw message