carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1720: [CARBONDATA-1935]fix the backword compatibili...
Date Fri, 22 Dec 2017 15:32:48 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1720#discussion_r158511629
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/datatype/DataType.java
---
    @@ -31,7 +31,7 @@
       // size of the value of this data type, negative value means variable length
       private int sizeInBytes;
     
    -  DataType(int id, int precedenceOrder, String name, int sizeInBytes) {
    +  public DataType(int id, int precedenceOrder, String name, int sizeInBytes) {
    --- End diff --
    
    public is not needed, since DataTypes class is in same package


---

Mime
View raw message