carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gvramana <...@git.apache.org>
Subject [GitHub] carbondata pull request #1708: [CARBONDATA-1928] Seperate the properties for...
Date Fri, 22 Dec 2017 11:52:31 GMT
Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1708#discussion_r158479473
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
    @@ -573,23 +573,44 @@
       /**
        * NUMBER_OF_TRIES_FOR_LOAD_METADATA_LOCK
        */
    -  public static final int NUMBER_OF_TRIES_FOR_LOAD_METADATA_LOCK_DEFAULT = 3;
    +  public static final int NUMBER_OF_TRIES_FOR_CONCURRENT_LOCK_DEFAULT = 3;
    --- End diff --
    
    timeout check should be MAX_TIMEOUT_FOR_CONCURRENT_LOCK_DEFAULT = 1 sec, 
    NUMBER_OF_TRIES_FOR_CONCURRENT_LOCK  = 100;
    also write comment why bigger number


---

Mime
View raw message