carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From KanakaKumar <...@git.apache.org>
Subject [GitHub] carbondata pull request #1702: [CARBONDATA-1896] Clean files operation impro...
Date Fri, 22 Dec 2017 11:26:03 GMT
Github user KanakaKumar commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1702#discussion_r158474524
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
    @@ -178,6 +178,7 @@ case class CarbonLoadDataCommand(
             // First system has to partition the data first and then call the load data
             LOGGER.info(s"Initiating Direct Load for the Table : ($dbName.$tableName)")
             GlobalDictionaryUtil.updateTableMetadataFunc = updateTableMetadata
    +        DataLoadingUtil.deleteLoadsAndUpdateMetadata(isForceDeletion = false, table)
    --- End diff --
    
    Please add the purpose why we have to move deletion call from CarbonDataRDDFactory.scala
to here


---

Mime
View raw message