carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1675: [CARBONDATA-1862][PARTITION] Support compacti...
Date Wed, 20 Dec 2017 07:23:11 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1675#discussion_r157951789
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonMergerRDD.scala
---
    @@ -456,6 +470,33 @@ class CarbonMergerRDD[K, V](
         result.toArray(new Array[Partition](result.size))
       }
     
    +  private def getTaskNo(
    +      split: CarbonInputSplit,
    +      partitionTaskMap: util.Map[List[String], String]): String = {
    +    if (carbonLoadModel.getCarbonDataLoadSchema.getCarbonTable.isStandardPartitionTable)
{
    --- End diff --
    
    I remember their is a comment to rename `isStandardPartitionTable` to `isHivePartitionTable`
in earlier PR, it was not fixed?


---

Mime
View raw message