carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1674: [CARBONDATA-1859][CARBONDATA-1861][PARTITION]...
Date Tue, 19 Dec 2017 07:07:51 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1674#discussion_r157677188
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMap.java
---
    @@ -379,10 +397,21 @@ private void createSchema(SegmentProperties segmentProperties) throws
MemoryExce
             new UnsafeMemoryDMStore(indexSchemas.toArray(new CarbonRowSchema[indexSchemas.size()]));
       }
     
    -  private void createTaskMinMaxSchema(SegmentProperties segmentProperties) throws MemoryException
{
    +  private void createSummarySchema(SegmentProperties segmentProperties, List<String>
partitions)
    --- End diff --
    
    provide comment for this function


---

Mime
View raw message