carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1672: [CARBONDATA-1858][PARTITION] Support querying...
Date Tue, 19 Dec 2017 03:10:09 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1672#discussion_r157655675
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
    @@ -445,13 +447,11 @@ case class CarbonLoadDataCommand(
           case c: CatalogRelation => c
         }.head.asInstanceOf[LogicalPlan]
     
    +
    --- End diff --
    
    1.Ok, I have changed the method name. 
    2.It is just used InsertIntoCommand to let spark handles the partitioning so it does not
require to know anything about partitioning information.
    3. I don't see any common code to extract it, both if else has different logic.
    4. Added comment


---

Mime
View raw message