carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1672: [CARBONDATA-1858][PARTITION] Support querying...
Date Tue, 19 Dec 2017 02:49:12 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1672#discussion_r157653659
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
    @@ -445,13 +447,11 @@ case class CarbonLoadDataCommand(
           case c: CatalogRelation => c
         }.head.asInstanceOf[LogicalPlan]
     
    +
         val query: LogicalPlan = if (dataFrame.isDefined) {
    -      val timeStampformatString = CarbonProperties.getInstance()
    -        .getProperty(CarbonCommonConstants.CARBON_TIMESTAMP_FORMAT,
    -          CarbonCommonConstants.CARBON_TIMESTAMP_DEFAULT_FORMAT)
    +      var timeStampformatString = CarbonCommonConstants.CARBON_TIMESTAMP_DEFAULT_FORMAT
           val timeStampFormat = new SimpleDateFormat(timeStampformatString)
    -      val dateFormatString = CarbonProperties.getInstance().getProperty(CarbonCommonConstants
    -        .CARBON_DATE_FORMAT, CarbonCommonConstants.CARBON_DATE_DEFAULT_FORMAT)
    +      var dateFormatString = CarbonCommonConstants.CARBON_DATE_DEFAULT_FORMAT
           val dateFormat = new SimpleDateFormat(dateFormatString)
    --- End diff --
    
    No, the logic is different. Both use different formats


---

Mime
View raw message