carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1672: [CARBONDATA-1858][PARTITION] Support querying...
Date Tue, 19 Dec 2017 02:10:07 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1672#discussion_r157649340
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
    @@ -445,13 +447,11 @@ case class CarbonLoadDataCommand(
           case c: CatalogRelation => c
         }.head.asInstanceOf[LogicalPlan]
     
    +
    --- End diff --
    
    comment for line 437 (function signature):
    1. suggest to rename `loadDataWithPartition`
    2. from signature, user can not easily tell why it is for partition, there is no parameter
is partition related. It is similar to `CarbonDataRDDFactory.loadCarbonData` only, can we
make it more readable.
    3. there are many repeated code in if block and else block, can we extract common part
to anther function


---

Mime
View raw message