carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mohammadshahidkhan <...@git.apache.org>
Subject [GitHub] carbondata pull request #1666: [CARBONDATA-1900][Core,processing] Modify loa...
Date Mon, 18 Dec 2017 09:03:15 GMT
Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1666#discussion_r157428609
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/statusmanager/LoadMetadataDetails.java
---
    @@ -241,26 +248,28 @@ private long convertTimeStampToLong(String factTimeStamp) {
        * @return
        */
       public Long getTimeStamp(String loadStartTime) {
    -    Date dateToStr = null;
         try {
    -      dateToStr = parser.parse(loadStartTime);
    -      return dateToStr.getTime() * 1000;
    -    } catch (ParseException e) {
    -      LOGGER.error("Cannot convert" + loadStartTime + " to Time/Long type value" + e.getMessage());
    -      return null;
    +      // for new loads the factTimeStamp will be long string
    --- End diff --
    
    fixed


---

Mime
View raw message