carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From watermen <...@git.apache.org>
Subject [GitHub] carbondata pull request #1665: [CARBONDATA-1884] Add CTAS support to carbond...
Date Mon, 18 Dec 2017 06:51:32 GMT
Github user watermen commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1665#discussion_r157410277
  
    --- Diff: integration/spark2/src/main/spark2.2/CarbonSessionState.scala ---
    @@ -280,25 +280,26 @@ class CarbonOptimizer(
       }
     }
     
    -class CarbonSqlAstBuilder(conf: SQLConf, parser: CarbonSpark2SqlParser) extends
    -  SparkSqlAstBuilder(conf) {
    +class CarbonSqlAstBuilder(conf: SQLConf, parser: CarbonSpark2SqlParser, sparkSession:
SparkSession)
    +  extends SparkSqlAstBuilder(conf) {
     
    -  val helper = new CarbonHelperSqlAstBuilder(conf, parser)
    +  val helper = new CarbonHelperSqlAstBuilder(conf, parser, sparkSession)
     
       override def visitCreateHiveTable(ctx: CreateHiveTableContext): LogicalPlan = {
         val fileStorage = helper.getFileStorage(ctx.createFileFormat)
     
         if (fileStorage.equalsIgnoreCase("'carbondata'") ||
             fileStorage.equalsIgnoreCase("'org.apache.carbondata.format'")) {
           helper.createCarbonTable(ctx.createTableHeader,
    -          ctx.skewSpec,
    --- End diff --
    
    @jackylk We should use the right format at the first time, I mean use 2 blanks instead
of 4 blanks. We should avoid unrelated modify, so we can keep each MR with less diff. Better
to review and better to rebase.


---

Mime
View raw message