carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From watermen <...@git.apache.org>
Subject [GitHub] carbondata pull request #1665: [CARBONDATA-1884] Add CTAS support to carbond...
Date Mon, 18 Dec 2017 06:47:11 GMT
Github user watermen commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1665#discussion_r157409856
  
    --- Diff: integration/spark2/src/main/spark2.1/CarbonSessionState.scala ---
    @@ -259,25 +259,26 @@ object CarbonOptimizerUtil {
       }
     }
     
    -class CarbonSqlAstBuilder(conf: SQLConf, parser: CarbonSpark2SqlParser) extends
    -  SparkSqlAstBuilder(conf) {
    +class CarbonSqlAstBuilder(conf: SQLConf, parser: CarbonSpark2SqlParser, sparkSession:
SparkSession)
    +  extends SparkSqlAstBuilder(conf) {
     
    -  val helper = new CarbonHelperSqlAstBuilder(conf, parser)
    +  val helper = new CarbonHelperSqlAstBuilder(conf, parser, sparkSession)
     
       override def visitCreateTable(ctx: CreateTableContext): LogicalPlan = {
         val fileStorage = helper.getFileStorage(ctx.createFileFormat)
     
         if (fileStorage.equalsIgnoreCase("'carbondata'") ||
             fileStorage.equalsIgnoreCase("'org.apache.carbondata.format'")) {
           helper.createCarbonTable(ctx.createTableHeader,
    --- End diff --
    
    move `ctx.createTableHeader` to next line


---

Mime
View raw message